Fix ViewTransition crash in Mobile Safari #35337
Merged
+17
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 55480b4...95d7331 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Dec 9, 2025
Collaborator
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
I think this is probably ok.
Collaborator
|
Not sure if it fixes it in all cases though if the staleness also happens to apply to any of these. |
Collaborator
Author
|
Yea not sure, I guess let's try it and see if I can hit it again at some other codepath |
gaearon
changed the title
This was referenced Dec 10, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 14, 2025
Speculative fix to facebook#35336 written by Claude. I have verified that applying a similar patch locally to the repro from facebook#35336 does fix the crash. I'm not familiar enough with the underlying APIs to tell whether the fix is correct or sufficient. DiffTrain build for [61331f3](facebook@61331f3)
Collaborator
|
One unfortunate consequence of this is that if you spawn custom Animations using the refs passed to |
This was referenced Jan 19, 2026
sebmarkbage
added a commit
that referenced
this pull request
Jan 20, 2026
Follow up to #35337. During a gesture, we always cancel the original animation and create a new one that we control. That's the one we need to add to the set that needs to be cancelled. Otherwise future gestures hang. An unfortunate consequence is that any custom ones that you start e.g. with #35556 or through other means aren't automatically cleaned up (in fact there's not even a clean up callback yet). This can lead these to freeze the whole UI afterwards. It would be really good to get this fixed in browsers instead so we can revert #35337.
sebmarkbage
added a commit
that referenced
this pull request
Jan 20, 2026
…ts (#35564) Stacked on #35556 and #35559. Given that we don't automatically clean up all view transition animations since #35337 and browsers are buggy, it's important that you clean up any `Animation` started manually from the events. However, there was no clean up function for when the View Transition is forced to stop. This also makes it harder to clean up custom timers etc too. This lets you return a clean up function from all the events on `<ViewTransition>`.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…ts (#35564) Stacked on #35556 and #35559. Given that we don't automatically clean up all view transition animations since #35337 and browsers are buggy, it's important that you clean up any `Animation` started manually from the events. However, there was no clean up function for when the View Transition is forced to stop. This also makes it harder to clean up custom timers etc too. This lets you return a clean up function from all the events on `<ViewTransition>`. DiffTrain build for [c55ffb5](c55ffb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix to #35336 written by Claude.
I have verified that applying a similar patch locally to the repro from #35336 does fix the crash.
I'm not familiar enough with the underlying APIs to tell whether the fix is correct or sufficient.